Adds unequal (i.e. 2x1) binning and option to rotate the CCD by integer multiples of 90 degrees #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements RotateCCD effect which allows for integer rotations of the field by 90 degrees
|
All looks good to me! Thanks for the work @Raindogjones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default binning for OSIRIS-MAAT will be 2x1 and the new OSIRIS CCD is rotated 90deg with respect to the current one. To allow us to use the same trace files for both, its simplest to just allow the CCD to be rotated by 90 degrees.