psf_utils.rescale_kernel
: fix for negative shifts
#177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
psf_utils.rescale_kernel()
, the shiftsdx
anddy
typically have small absolute values. When a shift is negative, e.g.dy = -1
, the previous code cuts the image toimage[:2*abs(dy), :]
, i.e.image[:2, ]
. This makes the image very narrow in the y direction... The intended functionality is to cut 2 rows from the top, this is achieved by the new codeimage[:2*dy, :]
, i.e.image[:-2, :]
. The x direction was also wrong for negativedx
, the current code is symmetric in both directions.