Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oc/rectification #237

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Oc/rectification #237

merged 2 commits into from
Jun 28, 2023

Conversation

oczoske
Copy link
Collaborator

@oczoske oczoske commented Jun 28, 2023

This adds a few unit tests.

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.21 🎉

Comparison is base (f1a8239) 74.93% compared to head (89cbbc2) 75.14%.

Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #237      +/-   ##
==============================================
+ Coverage       74.93%   75.14%   +0.21%     
==============================================
  Files             149      152       +3     
  Lines           15406    15664     +258     
==============================================
+ Hits            11544    11771     +227     
- Misses           3862     3893      +31     
Impacted Files Coverage Δ
...esim/tests/tests_effects/test_SpectralTraceList.py 96.07% <ø> (ø)
...pesim/tests/mocks/py_objects/trace_list_objects.py 83.96% <100.00%> (+0.76%) ⬆️
...tests/tests_effects/test_SpectralTraceListUtils.py 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oczoske oczoske merged commit cf85df5 into dev_master Jun 28, 2023
8 checks passed
@oczoske oczoske deleted the oc/rectification branch June 30, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant