Run notebook download test for only one configuration #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## dev_master #255 +/- ##
===========================================
Coverage 80.85% 80.85%
===========================================
Files 143 143
Lines 14676 14676
===========================================
Hits 11866 11866
Misses 2810 2810 ☔ View full report in Codecov by Sentry. |
|
If we only run it on one version of Python, do you think it makes more sense to use the highest (3.11) or the lowest (3.8) one we support? |
|
I was asking myself that too. I decided that the latest would be fine because the other tests (e.g. the minimum dependencies test) should cover the lowest supported version. |
teutoburg
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now run the notebook download test for only one configuration.
The idea behind this test is to run the notebooks at least once a night in the same way that a new user would. That's why it should download the IRDB in the same way as this new user would. However, we can also do this once, instead of 6 times, because the timeout might trigger because we do several of these at the same time, which a new user would not do.
This will hopefully make the nightly run green, and gives us time to properly address #254. The goal is to have the tests green again before we go on vacation and before Kieran gets back.