Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some plotting and representation improvements #260

Merged
merged 6 commits into from
Aug 9, 2023

oczosked

331e12a
Select commit
Loading
Failed to load commit list.
Merged

Some plotting and representation improvements #260

oczosked
331e12a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 9, 2023 in 0s

80.55% (-0.30%) compared to c700bc4

View this Pull Request on Codecov

80.55% (-0.30%) compared to c700bc4

Details

Codecov Report

Patch coverage: 28.24% and project coverage change: -0.30% ⚠️

Comparison is base (c700bc4) 80.85% compared to head (331e12a) 80.55%.

Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #260      +/-   ##
==============================================
- Coverage       80.85%   80.55%   -0.30%     
==============================================
  Files             143      143              
  Lines           14676    14736      +60     
==============================================
+ Hits            11866    11871       +5     
- Misses           2810     2865      +55     
Files Changed Coverage Δ
scopesim/optics/optical_train.py 43.84% <3.70%> (-4.36%) ⬇️
scopesim/effects/spectral_trace_list_utils.py 59.56% <11.11%> (-3.28%) ⬇️
scopesim/optics/optical_element.py 61.78% <25.00%> (-1.24%) ⬇️
scopesim/detector/detector_array.py 86.00% <33.33%> (-11.57%) ⬇️
scopesim/effects/spectral_trace_list.py 53.61% <52.94%> (+0.91%) ⬆️
scopesim/effects/effects.py 90.58% <70.00%> (+2.08%) ⬆️
scopesim/effects/detector_list.py 92.70% <100.00%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.