Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of FieldOfView and more warnings #265

Merged
merged 12 commits into from
Sep 5, 2023
Merged

Refactoring of FieldOfView and more warnings #265

merged 12 commits into from
Sep 5, 2023

Commits on Aug 29, 2023

  1. More warnings, some more checks

    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    476d948 View commit details
    Browse the repository at this point in the history

  2. Use set instead of np.unique wherever we don't need an array 

    Also remove redundant np.unique around self.waveset, which already returns unique elements.
    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    8990155 View commit details
    Browse the repository at this point in the history

  3. Eliminate "... is True/False"

    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    12eed02 View commit details
    Browse the repository at this point in the history

  4. Refactoring

    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f08e14c View commit details
    Browse the repository at this point in the history

  5. Not xfail tests that currently XPASS

    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    ebc3abe View commit details
    Browse the repository at this point in the history

  6. Docstrings

    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    c52ae6e View commit details
    Browse the repository at this point in the history

  7. Less variables, delete redundant code, minor fixes

    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4ecbc4b View commit details
    Browse the repository at this point in the history

  8. No more mutable default arguments! Also collections.abc. 

    And some de-nesting, and some renaming, and various small stuff.
    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    b6563ea View commit details
    Browse the repository at this point in the history

  9. General refactoring, using generators, update tests

    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2bfeab6 View commit details
    Browse the repository at this point in the history

  10. More refactoring in FOV

    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f7c4b24 View commit details
    Browse the repository at this point in the history

  11. Ah, turns out deepcopy IS needed here 

    only took 2 h to figure that one out...
    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    e6db1a1 View commit details
    Browse the repository at this point in the history

  12. silly float precision...

    @teutoburg
    teutoburg committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    bbe822c View commit details
    Browse the repository at this point in the history