Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring #272

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Minor refactoring #272

merged 4 commits into from
Sep 14, 2023

Conversation

teutoburg
Copy link
Contributor

See commit msgs for details.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 96.00% and project coverage change: -0.01% ⚠️

Comparison is base (7650119) 80.19% compared to head (57f84f0) 80.19%.

Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #272      +/-   ##
==============================================
- Coverage       80.19%   80.19%   -0.01%     
==============================================
  Files             143      143              
  Lines           14792    14791       -1     
==============================================
- Hits            11862    11861       -1     
  Misses           2930     2930              
Files Changed Coverage Δ
scopesim/effects/metis_lms_trace_list.py 31.55% <0.00%> (ø)
scopesim/effects/detector_list.py 92.70% <100.00%> (ø)
scopesim/effects/psfs.py 71.80% <100.00%> (ø)
scopesim/effects/spectral_trace_list.py 60.62% <100.00%> (ø)
scopesim/optics/image_plane_utils.py 93.39% <100.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg marked this pull request as ready for review September 14, 2023 12:51
Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hugobuddel hugobuddel merged commit a1f621e into dev_master Sep 14, 2023
19 checks passed
@teutoburg teutoburg deleted the fh/refac branch September 14, 2023 13:06
@teutoburg teutoburg added the refactor Implementation improvement label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Implementation improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants