Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one Error and related WCS changes #276

Merged
merged 47 commits into from
Oct 3, 2023
Merged

Fix off-by-one Error and related WCS changes #276

merged 47 commits into from
Oct 3, 2023

Commits on Sep 13, 2023

  1. Fix wcs issues causing off-by-one error

    @teutoburg
    teutoburg committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a52b9fc View commit details
    Browse the repository at this point in the history

  2. Attempt to fix now-broken tests...

    @teutoburg
    teutoburg committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    471ad10 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. Correct header in mock HDUs

    @teutoburg
    teutoburg committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    e2ff4fa View commit details
    Browse the repository at this point in the history

  2. attempt to fix broken stuff

    @teutoburg
    teutoburg committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    aca8aaa View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Take WCS unit from header

    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    dadfd28 View commit details
    Browse the repository at this point in the history

  2. Fix off-center CRPIX

    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f094c03 View commit details
    Browse the repository at this point in the history

  3. formatting

    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    d44a7c8 View commit details
    Browse the repository at this point in the history

  4. workaround for cube footprint

    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    ed12746 View commit details
    Browse the repository at this point in the history

  5. Correct shift of CRPIX when rescaling. 

    Before, this was just a multiplication by the zoom factor,
which can produce wrong results even in simple cases.

The solution in place now will probably only work for LINEAR WCSs.
    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    74522ad View commit details
    Browse the repository at this point in the history

  6. Fix wrong CRPIX in mock PSF

    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    af2f0db View commit details
    Browse the repository at this point in the history

  7. Fix various mock WCSs

    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f37b992 View commit details
    Browse the repository at this point in the history

  8. xfailing this because I don't understand how it's supposed to pass

    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    24fa2b1 View commit details
    Browse the repository at this point in the history

  9. Prepare to add more strict test (which would now fail 1/4 cases)

    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    5834bef View commit details
    Browse the repository at this point in the history

  10. comments and formatting

    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f9da90c View commit details
    Browse the repository at this point in the history

  11. Use approx to handle float-point madness

    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0b0def4 View commit details
    Browse the repository at this point in the history

  12. This test previously assumed that the point source will stay on on ce… 

    …ntral

pixel, which gets all the flux. However, this was a wrong assumption
based on an effect of the off-by-one error. Given an even number of pixels
along both axes of the canvas, a source perfectly in the center should be
spread out over the 4 central pixels, which now works. With this change,
the test still tests the exact same thing, just in a more general and
correct way.
    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    087500b View commit details
    Browse the repository at this point in the history

  13. The numbers used previously make little sense, see comments.

    @teutoburg
    teutoburg committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    48691da View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. too many dots in import

    @teutoburg
    teutoburg committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    faa754f View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Always use deg for FOV header

    @teutoburg
    teutoburg committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    d3d05ed View commit details
    Browse the repository at this point in the history

  2. Hinder heinous header horsing

    @teutoburg
    teutoburg committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    e821957 View commit details
    Browse the repository at this point in the history

  3. remove temporary "fixes"

    @teutoburg
    teutoburg committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    7224d17 View commit details
    Browse the repository at this point in the history

  4. Make sure header dimensions are correct

    @teutoburg
    teutoburg committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    e07be70 View commit details
    Browse the repository at this point in the history

  5. minor fixes

    @teutoburg
    teutoburg committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    047a0b8 View commit details
    Browse the repository at this point in the history

  6. Fix test, add one

    @teutoburg
    teutoburg committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    bb58de9 View commit details
    Browse the repository at this point in the history

  7. Remove commented-out code, fix some comments

    @teutoburg
    teutoburg committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    752c9bb View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Improve footprint functions, add table footprint function. 

    Change API of calc_footprint to return corner in the same format as
astropy.wcs.WCS.calc_footprint, which is now used internally.
    @teutoburg
    teutoburg committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    5bd8580 View commit details
    Browse the repository at this point in the history

  2. Adapt to new calc_footprint return format. 

    The affected parts could be improved, but for now just get it to work.
    @teutoburg
    teutoburg committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    38904ff View commit details
    Browse the repository at this point in the history

  3. Simplify quantify from table and unit from table functions

    @teutoburg
    teutoburg committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    bd9fa47 View commit details
    Browse the repository at this point in the history

  4. Improve implementation of image_plane_utils, adjust tests accordingly

    @teutoburg
    teutoburg committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    5c007db View commit details
    Browse the repository at this point in the history

  5. Use zip...

    @teutoburg
    teutoburg committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    ee53e29 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev_master' into fh/off-by-one

    @teutoburg
    teutoburg committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    44d58ac View commit details
    Browse the repository at this point in the history

  7. Fix Warnings

    @teutoburg
    teutoburg committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    196297e View commit details
    Browse the repository at this point in the history

  8. just because it says DeprecationWarning, doesn't mean it is one...

    @teutoburg
    teutoburg committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    7b0bd6b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Fix uniform illumination test

    @teutoburg
    teutoburg committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    07f2a1b View commit details
    Browse the repository at this point in the history

  2. Revert changes to extract_area_from_table and change mock data instead

    @hugobuddel
    hugobuddel committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1b21cdc View commit details
    Browse the repository at this point in the history

  3. Merge pull request #277 from AstarVienna/hb/extractareafromtable 

    Revert changes to extract_area_from_table and change mock data instead
    @teutoburg
    teutoburg committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    a54514e View commit details
    Browse the repository at this point in the history

  4. Fix type of naxis assignment 

    Co-authored-by: Hugo Buddelmeijer <hugo@buddelmeijer.nl>
    @teutoburg @hugobuddel
    teutoburg and hugobuddel committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    80af42a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Attempt to fix off-by-0.5

    @teutoburg
    teutoburg committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    b5cc394 View commit details
    Browse the repository at this point in the history

  2. remove offset, this caused more problems than it solved

    @teutoburg
    teutoburg committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    fa8a149 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Make better use of new footprint return format

    @teutoburg
    teutoburg committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8089068 View commit details
    Browse the repository at this point in the history

  2. Split header creation function

    @teutoburg
    teutoburg committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    1274338 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. minor fixes

    @teutoburg
    teutoburg committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9fda39f View commit details
    Browse the repository at this point in the history

  2. more logging

    @teutoburg
    teutoburg committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    3469ca5 View commit details
    Browse the repository at this point in the history

  3. another off-by-something

    @teutoburg
    teutoburg committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    782f7c7 View commit details
    Browse the repository at this point in the history

  4. log warning instead of error, to pass CI

    @teutoburg
    teutoburg committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e8dd0ee View commit details
    Browse the repository at this point in the history

  5. Better rounding, some comments

    @teutoburg
    teutoburg committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    54a5c4b View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Add fallback option to rescale_imagehdu to pass notebooks.

    @teutoburg
    teutoburg committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    2b6a58e View commit details
    Browse the repository at this point in the history