Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements for Python 3.12 support, ignore some warnings #289

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

teutoburg
Copy link
Contributor

To get rid of a DepracationWarning about utcfromtimestamp from a dependency inside matplotlib...

@teutoburg teutoburg added the dependencies Related to or updating any dependencies label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7da0dd3) 79.92% compared to head (56c5411) 79.92%.
Report is 3 commits behind head on dev_master.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev_master     #289   +/-   ##
===========================================
  Coverage       79.92%   79.92%           
===========================================
  Files             143      143           
  Lines           14917    14917           
===========================================
  Hits            11922    11922           
  Misses           2995     2995           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg
Copy link
Contributor Author

Hmm, it's still there because the warning apparently occurs upon import and not use of dateutils inside matplotlib. This might be hard to get rid of, unless dateutils gets updated or matplotlib decides to ditch it entirely.

Also, the minimum dependency tests can't resolve numpy...

Maybe just ignore that particular warning for now, so things don't fail for no real reason...

@hugobuddel
Copy link
Collaborator

Fine with me to explicitly ignore the DeprecationWarning and fix it later. The goal of filterwarnings = "error" is to prevent ignoring deprecation warnings by accident and have them bite us at an inconvenient time. As in, I had to fix ScopeSim because things broke overnight because some functionality in a dependency was removed after years of deprecation.

The idea behind the minimum dependencies test was that it should catch problems with people upgrading ScopeSim, but not e.g. numpy, and then having things break. That logic does not apply here, because Python 3.12 is new. Unfortunately, there doesn't seem to be a version of numpy that both supports Python 3.8 and 3.12, so maybe we should rethink this test.

@hugobuddel
Copy link
Collaborator

The minimum dependencies test only runs for Python 3.8, so my comment was invalid. Perhaps we can just upgrade to numpy >= 1.20

@teutoburg teutoburg marked this pull request as ready for review October 30, 2023 20:26
@teutoburg teutoburg changed the title Require matplotlib>=3.7.2 for Python 3.12 support Update requirements for Python 3.12 support, ignore some warnings Oct 30, 2023
@teutoburg teutoburg merged commit 091cf19 into dev_master Oct 30, 2023
22 checks passed
@teutoburg teutoburg deleted the fh/mpl372 branch October 30, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to or updating any dependencies
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants