Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing for 0.7.1 #297

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Preparing for 0.7.1 #297

merged 2 commits into from
Nov 17, 2023

Conversation

teutoburg
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d19865e) 80.04% compared to head (aca6cf2) 80.04%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev_master     #297   +/-   ##
===========================================
  Coverage       80.04%   80.04%           
===========================================
  Files             145      145           
  Lines           14771    14771           
===========================================
  Hits            11823    11823           
  Misses           2948     2948
Files Coverage Δ
scopesim/version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg marked this pull request as draft November 10, 2023 12:18
@teutoburg
Copy link
Contributor Author

There might be a problem with Skycalc_ipy. Converting this to draft while I investigate, to avoid releasing something broken...

@teutoburg teutoburg marked this pull request as ready for review November 10, 2023 16:45
@teutoburg
Copy link
Contributor Author

The skycalc thing was due to an outdated local install. We should be good to go (as indicated by the passing tests).

hugobuddel
hugobuddel approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugobuddel
Copy link
Collaborator

Shall we release this? Last release without poetry? :-)

@teutoburg
Copy link
Contributor Author

Yes, let's go ahead with this!

@teutoburg teutoburg merged commit c6b73bd into dev_master Nov 17, 2023
22 checks passed
@teutoburg teutoburg deleted the fh/towards071 branch November 17, 2023 10:38
@hugobuddel hugobuddel mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugobuddel hugobuddel hugobuddel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ScopeSim-development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teutoburg @hugobuddel