Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI run for notebooks #300

Merged
merged 8 commits into from
Nov 20, 2023
Merged

Improve CI run for notebooks #300

merged 8 commits into from
Nov 20, 2023

Conversation

teutoburg
Copy link
Contributor

@teutoburg teutoburg commented Nov 19, 2023

This will hopefully reduce the spam from progress bars in the GitHub Actions logs, as indicated in tqdm's release notes.

Also now using GitHub's Step Summary feature to get somewhat nicer output from the notebooks tests.

This will hopefully reduce the spam from progress bars in GH actions logs.
@teutoburg teutoburg self-assigned this Nov 19, 2023
@teutoburg teutoburg added the dependencies Related to or updating any dependencies label Nov 19, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6b73bd) 80.04% compared to head (9783752) 80.04%.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev_master     #300   +/-   ##
===========================================
  Coverage       80.04%   80.04%           
===========================================
  Files             145      145           
  Lines           14771    14771           
===========================================
  Hits            11823    11823           
  Misses           2948     2948           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg changed the title Increase tqdm version requirement Improve CI run for notebooks Nov 19, 2023
@teutoburg teutoburg added the tests Related to unit or integration tests label Nov 19, 2023
@teutoburg teutoburg force-pushed the fh/tqdm branch 2 times, most recently from f2654c1 to c900712 Compare November 19, 2023 18:19
@teutoburg teutoburg marked this pull request as ready for review November 19, 2023 20:46
Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Logs look much better now

@teutoburg teutoburg merged commit 36df176 into dev_master Nov 20, 2023
22 checks passed
@teutoburg teutoburg deleted the fh/tqdm branch November 20, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to or updating any dependencies tests Related to unit or integration tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants