Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic sky coordinates (WCS) to ScopeSim output #307

Merged
merged 12 commits into from
Dec 13, 2023
Merged

Add basic sky coordinates (WCS) to ScopeSim output #307

merged 12 commits into from
Dec 13, 2023

Commits on Dec 10, 2023

  1. Remove filenames from header

    @teutoburg
    teutoburg committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    fd0d620 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Formatting

    @teutoburg
    teutoburg committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    2aed1cc View commit details
    Browse the repository at this point in the history

  2. Use astropy quantities (urgh) to avoid deg vs. arcsec issues

    @teutoburg
    teutoburg committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    90d69c0 View commit details
    Browse the repository at this point in the history

  3. Adapt to changes

    @teutoburg
    teutoburg committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    0e4671a View commit details
    Browse the repository at this point in the history

  4. Add and use sky <-> det wcs convenience functions and tests

    @teutoburg
    teutoburg committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    7e9f363 View commit details
    Browse the repository at this point in the history

  5. Numpy...

    @teutoburg
    teutoburg committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    e7f9a39 View commit details
    Browse the repository at this point in the history

  6. Add sky header in detector HDU 

    Signed-off-by: teutoburg <ghost@instruct.at>
    @teutoburg
    teutoburg committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    705cc92 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Remove obsolete basic WCS creation

    @teutoburg
    teutoburg committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    52dc24c View commit details
    Browse the repository at this point in the history

  2. Remove messy WCS manipulation by SpectralTraceList 

    This should not happen here at all. Either this is done in apply_to
anyway, or need to do it somewhere else, but not here.
    @teutoburg
    teutoburg committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    081c5e0 View commit details
    Browse the repository at this point in the history

  3. Some cleanup

    @teutoburg
    teutoburg committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7024743 View commit details
    Browse the repository at this point in the history

  4. Make attribute private, add some comments

    @teutoburg
    teutoburg committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    b5d0f92 View commit details
    Browse the repository at this point in the history

  5. Make image_plane_id a property 

    Because why not...
    @teutoburg
    teutoburg committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    69fa9a8 View commit details
    Browse the repository at this point in the history