Migrate to Poetry #314
Migrate to Poetry #314
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev_master #314 +/- ##
==============================================
- Coverage 80.77% 77.04% -3.74%
==============================================
Files 148 57 -91
Lines 14869 7707 -7162
==============================================
- Hits 12011 5938 -6073
+ Misses 2858 1769 -1089 ☔ View full report in Codecov by Sentry. |
|
Currently failing Notebook tests will be addressed in a separate PR. In principle they're working: Based on this branch (and further commits) |
|
Should read the docs be updated? |
Probably. I'll have a look. |
1 similar comment
Probably. I'll have a look. |
| "more-itertools>=9.0", | ||
| "tqdm>=4.66.1", | ||
| [tool.poetry.dependencies] | ||
| python = ">=3.8,<3.12" |
There was a problem hiding this comment.
This <3.12 makes our tests fail (https://github.com/AstarVienna/irdb/actions/runs/7297735519/job/19887475308?pr=150) because the testing matrix includes 3.12 (AstarVienna/DevOps#8).
This problem was not caught because this PR uses: AstarVienna/DevOps/.github/workflows/tests.yml@poetry, where Python 3.12 is explicitly excluded (AstarVienna/DevOps@1f9f5f1).
More importantly than our tests failing, is that we currently do not support Python 3.12 anymore! I'd rather have us drop support for Python 3.8 early, rather than adding Python 3.12 support late.
Ultimately it will be impossible to find versions of dependencies that work for all supported Python versions (see commit message in AstarVienna/DevOps@1f9f5f1), so this current workflow is untenable.
Perhaps we can split the tests up: a single test using the poetry.lock file, and a full matrix test allowing free dependencies from pyproject.toml ?
Fear not, the huge diff is mostly from
poetry.lock