Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow runnotebooks.sh to run without arguments #330

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

hugobuddel
Copy link
Collaborator

@hugobuddel hugobuddel commented Jan 8, 2024

This should make the ScopeSim_Data nightly run work.

This follows https://betterdev.blog/minimal-safe-bash-script-template/

Closes #328

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca45d9d) 77.04% compared to head (fa93b07) 77.04%.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev_master     #330   +/-   ##
===========================================
  Coverage       77.04%   77.04%           
===========================================
  Files              57       57           
  Lines            7705     7705           
===========================================
  Hits             5936     5936           
  Misses           1769     1769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg added the tests Related to unit or integration tests label Jan 8, 2024
Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes beyond my knowledge of bash, but if it works, I guess it's fine 👍

@hugobuddel hugobuddel merged commit d762bcf into dev_master Jan 8, 2024
15 checks passed
@hugobuddel hugobuddel deleted the hb/fixrunnotebooks branch January 8, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to unit or integration tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make runnotebooks.sh work without parameters
2 participants