Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new linkchecker action #335

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Use new linkchecker action #335

merged 1 commit into from
Jan 10, 2024

Conversation

hugobuddel
Copy link
Collaborator

@hugobuddel hugobuddel commented Jan 10, 2024

After merging this, I'll add it to all the other repos.

That's also why I used master, dev_master, and main, because that way we can keep the file the same between all the repos

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ea1201) 77.04% compared to head (536062b) 77.04%.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev_master     #335   +/-   ##
===========================================
  Coverage       77.04%   77.04%           
===========================================
  Files              57       57           
  Lines            7705     7705           
===========================================
  Hits             5936     5936           
  Misses           1769     1769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg
Copy link
Contributor

Interesting, we're still getting httpx.HTTPStatusError: Client error '403 rate limit exceeded' from the GitHub-based package download tests occasionally. Those tests were disabled for a while for that exact reason, but I reenabled them after moving to httpx...

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now go to bed 😂

@teutoburg teutoburg added the tests Related to unit or integration tests label Jan 10, 2024
@hugobuddel hugobuddel merged commit fc6d817 into dev_master Jan 10, 2024
12 of 16 checks passed
@hugobuddel hugobuddel deleted the hb/updatelinkcheck branch January 10, 2024 09:35
@hugobuddel
Copy link
Collaborator Author

LGTM, now go to bed 😂

Says who 😄

I was watching https://www.twitch.tv/videos/2027847540 , a classic tetris match between the first three players who have managed to crash the game. They can play so accurately, it's crazy! For context see https://www.youtube.com/watch?v=GuJ5UuknsHU

@hugobuddel
Copy link
Collaborator Author

Interesting, we're still getting httpx.HTTPStatusError: Client error '403 rate limit exceeded' from the GitHub-based package download tests occasionally. Those tests were disabled for a while for that exact reason, but I reenabled them after moving to httpx...

Yeah noticed that too. It makes sense if there are 12 jobs running simultaneously.

@hugobuddel
Copy link
Collaborator Author

All repositories (except DevOps) now use the same markdown_link_check.yml, using the one from DevOps:

$ md5sum $(find . -name markdown_link_check.yml)
1c8f628159076c1ba9c407c7b0a46cb0  ./irdb/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0  ./ScopeSim_Templates/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0  ./speXtra/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0  ./AnisoCADO/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0  ./Pyckles/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0  ./skycalc_ipy/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0  ./ScopeSim/.github/workflows/markdown_link_check.yml
366af807eaab5c4d3f7afbb75b53cffb  ./DevOps/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0  ./HowManyBloodyPhotons/.github/workflows/markdown_link_check.yml
1c8f628159076c1ba9c407c7b0a46cb0  ./astar-utils/.github/workflows/markdown_link_check.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to unit or integration tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants