-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use logger instead of print #353
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev_master #353 +/- ##
==============================================
- Coverage 75.57% 75.57% -0.01%
==============================================
Files 59 59
Lines 7869 7868 -1
==============================================
- Hits 5947 5946 -1
Misses 1922 1922 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I be nitpicky about lazy string formatting in logging? 😇
Co-authored-by: teutoburg <73600109+teutoburg@users.noreply.github.com>
Co-authored-by: teutoburg <73600109+teutoburg@users.noreply.github.com>
Co-authored-by: teutoburg <73600109+teutoburg@users.noreply.github.com>
Co-authored-by: teutoburg <73600109+teutoburg@users.noreply.github.com>
Thanks. It is better this way, so maybe I was just lazy. I didn't do it because this message will usually be shown under normal circumstances anyway, so it doesn't help much to make them lazy. But the real reason is that I didn't want to look up how to covert the There are still some more print statements to convert; I was just going through some notebooks and tried to clean up their output. Hence also #352 (the tqdm PR). |
Replace some print messages with logging