Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further harmonize filename kwarg #361

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Further harmonize filename kwarg #361

merged 2 commits into from
Feb 3, 2024

Conversation

teutoburg
Copy link
Contributor

Following AstarVienna/irdb#147, this further harmonizes file_name to filename and throw a warning if the old one is still used, as suggested by @hugobuddel in that same PR.

@teutoburg teutoburg added the refactor Implementation improvement label Feb 2, 2024
@teutoburg teutoburg self-assigned this Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7cfe1f5) 75.14% compared to head (59d509e) 75.13%.

Files Patch % Lines
scopesim/effects/data_container.py 50.00% 1 Missing ⚠️
scopesim/effects/metis_lms_trace_list.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #361      +/-   ##
==============================================
- Coverage       75.14%   75.13%   -0.02%     
==============================================
  Files              58       58              
  Lines            8004     8006       +2     
==============================================
  Hits             6015     6015              
- Misses           1989     1991       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I I verified that we don't use file_name anywhere else for the file of an Effect.

@teutoburg teutoburg merged commit c7ffb96 into dev_master Feb 3, 2024
24 of 25 checks passed
@teutoburg teutoburg deleted the fh/filename branch February 3, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Implementation improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants