Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cmds and kwargs stuff #369

Merged
merged 1 commit into from
Feb 15, 2024
Merged

More cmds and kwargs stuff #369

merged 1 commit into from
Feb 15, 2024

Conversation

hugobuddel
Copy link
Collaborator

Fix things that I broke in context of #368

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (050fc28) 74.35% compared to head (4f5c9a9) 71.89%.

Files Patch % Lines
scopesim/effects/spectral_trace_list.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #369      +/-   ##
==============================================
- Coverage       74.35%   71.89%   -2.46%     
==============================================
  Files              56       56              
  Lines            7833     7835       +2     
==============================================
- Hits             5824     5633     -191     
- Misses           2009     2202     +193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugobuddel hugobuddel merged commit dff88f7 into dev_master Feb 15, 2024
23 of 25 checks passed
@teutoburg teutoburg deleted the hb/morefixes branch March 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant