Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make required_keys always a set #383

Merged
merged 7 commits into from
Mar 2, 2024
Merged

Make required_keys always a set #383

merged 7 commits into from
Mar 2, 2024

Commits on Mar 2, 2024

  1. required_keys always as set and as class attribute

    @teutoburg
    teutoburg committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    8c5b328 View commit details
    Browse the repository at this point in the history

  2. Adapt check_keys for set

    @teutoburg
    teutoburg committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    43683b3 View commit details
    Browse the repository at this point in the history

  3. Docstring and typing for check_keys.

    @teutoburg
    teutoburg committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    25a7180 View commit details
    Browse the repository at this point in the history

  4. Include empty required_keys in Effect base class

    @teutoburg
    teutoburg committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    5993530 View commit details
    Browse the repository at this point in the history

  5. Not sure how that got back in, probably the rebase. Anyway...

    @teutoburg
    teutoburg committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    9ac4397 View commit details
    Browse the repository at this point in the history

  6. Simplify this, because set() on a dict returns the keys anyway

    @teutoburg
    teutoburg committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    9dd32f2 View commit details
    Browse the repository at this point in the history

  7. Further simplify this

    @teutoburg
    teutoburg committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    192a588 View commit details
    Browse the repository at this point in the history