Fix specref not always an integer #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code work, although I'm not sure why.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
- Coverage 74.92% 74.84% -0.09%
==========================================
Files 56 56
Lines 7777 7819 +42
==========================================
+ Hits 5827 5852 +25
- Misses 1950 1967 +17 ☔ View full report in Codecov by Sentry. |
teutoburg
approved these changes
May 13, 2024
|
Also, @JenniferKarr please feel free to click the "request review" for me on things like that. I don't always get notified from GitHub otherwise, and only saw this PR by coincidence 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typecast ref to integer FOV.py; I needed this to make the pinhole mask code work, although I'm not sure why.
If it doesn't break anything else, merging to master will let the simulated data scripts run from the main branches of the various softwares.