Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore PytestRemovedIn8Warning. #420

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

hugobuddel
Copy link
Collaborator

The main point of treating warnings as errors in the tests is to detect deprecation warningns early, so we have time to fix them before they become errors.

We should only ignore deprecation warnings in very specific cases where we have ensured that doing so is save and will not cause problems.

At the very least, every ignored deprecation warning should come with an issue that describes what is required to fix the problem.

The main point of treating warnings as errors in the tests is
to detect deprecation warningns early, so we have time to fix
them before they become errors.

We should only ignore deprecation warnings in very specific cases
where we have ensured that doing so is save and will not cause
problems.

At the very least, every ignored deprecation warning should come
with an issue that describes what is required to fix the problem.
@hugobuddel hugobuddel requested a review from teutoburg May 24, 2024 08:41
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.83%. Comparing base (68832ab) to head (35e9a05).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   74.83%   74.83%           
=======================================
  Files          56       56           
  Lines        7824     7824           
=======================================
  Hits         5855     5855           
  Misses       1969     1969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what happens then...

@hugobuddel
Copy link
Collaborator Author

I'll let the notebook test here finish to see whether that causes any warnings.

I had never seen that PytestRemovedIn8Warning, so I don't know what should trigger it. Do you recall?

@hugobuddel hugobuddel merged commit 4aee0cd into main May 24, 2024
25 checks passed
@hugobuddel hugobuddel deleted the hb/donotignoredeprecations branch May 24, 2024 08:56
@hugobuddel
Copy link
Collaborator Author

FWIW, PytestRemovedIn8Warning itself is removed in a later version of pytest, so the test I created to use the latest version of all dependencies, AstarVienna/ScopeSim_Data#16, failed: https://github.com/AstarVienna/ScopeSim_Data/actions/runs/9220738690/job/25368339300#step:5:1052

@teutoburg
Copy link
Contributor

Do you recall?

Can't remember. There must have been a good reason once, but that could very well be outdated...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants