Split PSF and Electronic effects into subpackages #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove test specific to fov_grid, skip tests implicitly using fov_grid.
teutoburg
added
refactor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
==========================================
+ Coverage 75.32% 75.41% +0.09%
==========================================
Files 56 64 +8
Lines 7821 7830 +9
==========================================
+ Hits 5891 5905 +14
+ Misses 1930 1925 -5 ☔ View full report in Codecov by Sentry. |
hugobuddel
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
Thanks for the refactoring.
I'm trusting you that nothing really changed in the code. The tests didn't change much, so should be OK.
And I'm trusting @astronomyk that fov_grid() is indeed not necessary anymore.
I got a bit distracted when reviewing this, so I'm a bit late.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the
effects.psfsandeffects.electronicmodules were getting rather large and unübersichtlich, so I decided why not split them up into separate modules and group those in a subpackage (aka folder). The outside behavior is unchanged, any imports still work the same way.Along the way I also did some minor refactoring and remove the (according to @astronomyk) redundant and obsolete
.fov_grid()methods from the PSF classes. Also removedpsf_utils.py, because each utils function was only used by one of the now four psf submodules, so is logically better kept there.Also tested against IRDB, without issues.