Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace file_name with filename in Effect kwargs #147

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Replace file_name with filename in Effect kwargs #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
929a405
Harmonize names and filenames
hugobuddel Nov 27, 2023
0887d78
Rename file_name arg to filename
hugobuddel Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion HAWKI/HAWKI_H2RG.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ effects :
description : Quantum efficiency curves for each detector
class : QuantumEfficiencyCurve
kwargs :
file_name : QE_detector_H2RG.dat
filename : QE_detector_H2RG.dat

- name: exposure_action
description: Summing up sky signal for all DITs and NDITs
Expand Down
2 changes: 1 addition & 1 deletion METIS/METIS_DET_IFU.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ properties:
readout_noise: 70 # electrons, AI on RvB: check
layout:
file_name: "FPA_metis_lms_layout.dat"
qe_curve:
quantum_efficiency:
file_name: "QE_detector_H2RG_METIS.dat"
linearity:
file_name: "FPA_linearity_HxRG.dat"
Expand Down
2 changes: 1 addition & 1 deletion METIS/METIS_DET_IMG_LM.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ effects:
description: METIS IMG-LM detector array list
class: DetectorList
kwargs:
file_name: "!DET.layout.file_name"
filename: "!DET.layout.file_name"

- name: detector_readout_parameters
description: Readout parameters for H2RG detector (fast and slow modes)
Expand Down
4 changes: 2 additions & 2 deletions METIS/METIS_DET_IMG_N_Aquarius.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ effects:
description: METIS detector array list
class: DetectorList
kwargs:
file_name: "!DET.layout.file_name"
filename: "!DET.layout.file_name"

- name: detector_readout_parameters
description: Readout modes for Aquarius detector
Expand All @@ -54,7 +54,7 @@ effects:
class: QuantumEfficiencyCurve
include: false # QE file does not exist
kwargs:
file_name: "!DET.qe_curve.file_name"
filename: "!DET.qe_curve.file_name"

- name: auto_exposure
description: automatic determination of DIT and NDIT
Expand Down
4 changes: 2 additions & 2 deletions METIS/METIS_DET_IMG_N_GeoSnap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ effects:
description: METIS IMG-N detector array list
class: DetectorList
kwargs:
file_name: "!DET.layout.file_name"
filename: "!DET.layout.file_name"

- name: detector_readout_parameters
description: Readout modes for Geosnap detector (high and low capacity)
Expand Down Expand Up @@ -55,7 +55,7 @@ effects:
description: Quantum efficiency curves for each detector
class: QuantumEfficiencyCurve
kwargs:
file_name: "!DET.qe_curve.file_name"
filename: "!DET.qe_curve.file_name"

- name: auto_exposure
description: automatic determination of DIT and NDIT
Expand Down