Several fixes in preparation of the CainMap #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugobuddel
reviewed
Feb 26, 2024
hugobuddel
reviewed
Feb 26, 2024
This will still work with the ChainMap, albeit with a DeprecationWarning. Co-authored-by: Hugo Buddelmeijer <hugo@buddelmeijer.nl>
|
Urgh, this still has 3.8 in the matrix... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly harmonize the
set_modes, all in preparation of the UserCommands -> CainMap change in ScopeSim itself.There's now one failing test because the call signature of
UserCommands.set_modes()will change, but hasn't yet. TBH, I don't know why in that example this method is called at all, and not just put the modes in the init call. This seems to be the only place the method is called externally anyway...