Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more UserCommands as rc.currsys #157

Merged
merged 9 commits into from
Feb 28, 2024

Conversation

hugobuddel
Copy link
Collaborator

@hugobuddel hugobuddel commented Feb 26, 2024

Counterpart of AstarVienna/ScopeSim#377

@hugobuddel hugobuddel marked this pull request as draft February 26, 2024 22:19
@hugobuddel hugobuddel changed the title Hb/nomorecurrsysusercommands No more UserCommands as rc.currsys Feb 26, 2024
@hugobuddel
Copy link
Collaborator Author

All tests now pass using ScopeSim branch of AstarVienna/ScopeSim#377 . Have not yet tested all the notebooks.

@hugobuddel hugobuddel marked this pull request as ready for review February 27, 2024 00:18
@hugobuddel
Copy link
Collaborator Author

All tests now pass using ScopeSim branch of AstarVienna/ScopeSim#377 . Have not yet tested all the notebooks.

Did run all the notebooks locally

@hugobuddel
Copy link
Collaborator Author

All notebooks and tests pass with both ScopeSim dev_master and AstarVienna/ScopeSim#377 , so I suggest we

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Store IFU-example.ipynb with or without output? Otherwise, LGTM.

@teutoburg
Copy link
Contributor

  • release IRDB packages; at least those changed in this branch

I can do that part 👍

@hugobuddel
Copy link
Collaborator Author

Store IFU-example.ipynb with or without output? Otherwise, LGTM.

It would perhaps be more in line to remove the output. But perhaps it is good to have at least one copy of the output in the git history? Then we can always go back to that version to see what it should approximately look like? It's only 250kb

@hugobuddel
Copy link
Collaborator Author

I'll merge this. We can remove the output of the notebook later; which does mean it is in the history forever, but it isn't that large to store one version of it.

I think we only really need a new package of METIS; could you please make that @teutoburg ?

@hugobuddel hugobuddel merged commit 913d0f3 into dev_master Feb 28, 2024
8 of 9 checks passed
@hugobuddel
Copy link
Collaborator Author

So apparently the new IFU example notebook fails with the old ScopeSim. So I probably ran them incorrectly locally and perhaps other METIS notebooks fail too with ScopeSim 0.7.1. But perhaps we can't prevent that. So I'd say that if MICADO runs fine, then it's good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants