Add Quantization effect to METIS detector yamls #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teutoburg
added
enhancement
hugobuddel
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Looks good! But we can't test whether it works, because the CI fails due to #168. Maybe we should fix that first, because it would not surprise me if the quantization will also break some notebooks.
Try putting quantization as the final effect to avoid numpy issues that otherwise occur when adding floats to ints.
|
At least one METIS notebook fails with this. I'll get the |
|
We want to release the METIS Simulations tomorrow (Wednesday), so I'll fix this and merge it. |
|
casting to uint currently overflows to MAXINT, that is not supposed to happen. Well, negative fluxes shouldn't happen, but if they happen, they shouldn't be cast to extremely high values |
|
Fixed the overflow in AstarVienna/ScopeSim#414 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.