This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Enforced invariant to make sure auction duration can never exceed epoc… #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
androolloyd
approved these changes
Aug 3, 2023
| if (vaultFee > s.maxStrategistFee) { | ||
| revert IAstariaRouter.InvalidVaultFee(); | ||
| } | ||
| if (epochLength <= s.auctionWindow) { |
There was a problem hiding this comment.
this is implied from above where we check:
s.minEpochLength <= epochLength- and when filing
s.auctionWindow < s.minEpochLength(need to check this in the constructor as well)
Comment on lines
+296
to
298
| uint256 minLength = abi.decode(data, (uint256)); | ||
| if (minLength <= s.auctionWindow) revert InvalidFileData(); | ||
| s.minEpochLength = abi.decode(data, (uint256)).safeCastTo32(); |
There was a problem hiding this comment.
we don't need to decode data twice.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AST-869