This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
fix: Spearbit #77 donation amount to PublicVault #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something broke the test imports. |
dangerousfood
force-pushed
the
fix/spearbit-77
branch
2 times, most recently
from
0ec5e6f
to
1350908
Compare
androolloyd
force-pushed
the
fix/spearbit-77
branch
from
1350908
to
151da34
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a virtual balance to PublicVault, there is no clear way to determine between a balance received through a transfer vs a balance received through a deposit or repayment.
Before this the PR an amount could be borrowed from any balance available at the PublicVault. If that amount is liquidated and results in a decrease in the yIntercept it could underflow the yIntercept.
see: https://github.com/spearbit-audits/review-astaria2/issues/77 for more information