-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call Parking Action Improved by Adding Additional Parameter #229
base: master
Are you sure you want to change the base?
Conversation
Announce Channel in AsterNET not Available in ParkAction, fix for this issue AsterNET#228
Missing Variables forAnnounceChannel & TimeoutChannel and Replaced Channel 2 by TimeoutChannel Variable
AsterNET#228 (comment) This solution is working for me,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small issue of backward compatibility and some summary comments.
Otherwise it looks fine.
@skrusty we aren't gonna stop supporting Asterisk versions <12, right?
public string TimeoutChannel { get; set; } | ||
|
||
/// <summary> | ||
/// Set the Announcement Channel to receive the AMI Announcement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add the full parameter description shown on the Asterisk Documentation:
https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+ManagerAction_Park
Channel name to use when constructing the dial string that will be dialed if the parked channel times out. If TimeoutChannel is in a two party bridge with Channel, then TimeoutChannel will receive an announcement and be treated as having parked Channel in the same manner as the Park Call DTMF feature.
@@ -50,7 +54,12 @@ public override string Action | |||
/// <summary> | |||
/// Set the Channel where the Call will end up after the timeout is reached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add the full parameter description shown on the Asterisk Documentation:
https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+ManagerAction_Park
If specified, then this channel will receive an announcement when Channel is parked if AnnounceChannel is in a state where it can receive announcements (AnnounceChannel must be bridged). AnnounceChannel has no bearing on the actual state of the parked call.
Park Action Update Preserving the Backward Compatibility,
@@ -52,6 +70,16 @@ public override string Action | |||
/// </summary> | |||
public string Channel2 { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy way didn't work?
public string Channel2 { get { return TimeoutChannel; } set { TimeoutChanne = value; } }
Call Parking Action Improved by Adding Additional Parameter
Fixes #228