qt5-qpa-hwcomposer-plugin & timed: Add support for ambient mode. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to keep the screen on while in deep sleep mode. This is achieved by setting the power mode to HWC_POWER_MODE_DOZE_SUSPEND. https://android.googlesource.com/platform/hardware/libhardware/+/refs/heads/master/include/hardware/hwcomposer_defs.h#299 implies that the power mode needs to be changed to update the screen, but according to several tests (on sturgeon and smelt) this seems to be not necessary. Swapping the buffer while the screen is off still appears to update the screen.
It seems like there is no easy way to get a callback from when an event occurs. The only way is using voland. Which, on AsteroidOS, is used by the alarmclock app. So scheduling an event for use with ambient mode would actually show the alarmclock dialog (and update the screen). This is due to alarmclock using a D-Bus (systemd) service that triggers on any voland signal. I don't think there is a way to filter these events with systemd. Another thing that may be used is the `next_bootup_event` event. But this is not a reliable source, because alarmclock events also cause this signal, can cause multiple triggers at irregular intervals. Somehow we need to update the screen without triggering the alarmclock alarm dialog. The most straightforward way to do this is by adding a special `wakeup` type event, that doesn't trigger the voland event, but instead a new event.
|
I also can't think of anything better for timed :) that will do! |
|
Took years, But hozzah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for an Always on display functionality. Because qt5-qpa-hwcomposer-plugin & timed don't have a repo in the AsteroidOS organization. It may be easier to look in the separate commits for review:
MagneFire/qt5-qpa-hwcomposer-plugin@1c568ba
MagneFire/timed@28c579d
Other PRs that are also needed are:
And for devices I have tuned the ambient mode brightness setting for sturgeon and smelt:
Here is also an overview of what the watchfaces look like in ambient mode:
Of course this finally fixes AsteroidOS/asteroid#58