Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests for DDI and TwoSides #51

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Fix unit tests for DDI and TwoSides #51

merged 1 commit into from
Jan 17, 2022

Conversation

benedekrozemberczki
Copy link
Contributor

Summary

Incorrect shapes

  • Code passes all tests
  • Unit tests provided for these changes
  • Documentation and docstrings added for these changes

Changes

  • Shapes corrected

@codecov-commenter
Copy link

Codecov Report

Merging #51 (c358754) into main (b2e7532) will decrease coverage by 0.22%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   98.68%   98.45%   -0.23%     
==========================================
  Files          27       27              
  Lines         682      712      +30     
==========================================
+ Hits          673      701      +28     
- Misses          9       11       +2     
Impacted Files Coverage Δ
chemicalx/data/datasetloader.py 94.73% <71.42%> (-3.31%) ⬇️
chemicalx/data/__init__.py 100.00% <100.00%> (ø)
tests/unit/test_dataset.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f61eed...c358754. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the TWOSIDES dataset with molecular features Add the DDI Dataset from DeepDDI
3 participants