Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update citations and add additional testing #72

Merged
merged 6 commits into from
Feb 2, 2022
Merged

Update citations and add additional testing #72

merged 6 commits into from
Feb 2, 2022

Conversation

cthoyt
Copy link
Collaborator

@cthoyt cthoyt commented Feb 2, 2022 •
edited

Summary

This PR cleans up all of the citations and adds testing to make sure they're written properly

  • Unit tests provided for these changes
  • Documentation and docstrings added for these changes using the sphinx style

Changes

  • Add test for link to original issue
  • Add test for first line ending in citation
  • Add test for citation key ending in 4 digits

@cthoyt cthoyt marked this pull request as ready for review February 2, 2022 12:50
@benedekrozemberczki benedekrozemberczki merged commit 5449f96 into AstraZeneca:main Feb 2, 2022
@cthoyt cthoyt deleted the update-citations branch February 2, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benedekrozemberczki benedekrozemberczki benedekrozemberczki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cthoyt @benedekrozemberczki