New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate redundant functions #41
Annotate redundant functions #41
Conversation
I'm not really happy with this since the "canonical" implementation of some use the more esoteric name
Codecov Report
@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 16 16
Lines 886 894 +8
=======================================
+ Hits 884 892 +8
Misses 2 2
Continue to review full report at Codecov.
|
@benedekrozemberczki what do you think about changing the way the functions are annotated as redundant? |
@cthoyt Feel free to switch around the naming and choose the standard function and annotate the others as you see fit. |
issue with installing new version on conda environment
@benedekrozemberczki sorry that the diff is a bit messy - I did some reorganizing of the order of the function definitions. I opted to use the most descriptive names (e.g., use true positive rate over sensitivity) as the defaults. This PR also now introduces a helper function in the There's one bizarre quirk I noticed - the This PR is ready for review. |
Dear @cthoyt, This looks amazing - thank you for all of the work. For now, we will release 0.1.0. and do a bit of promotion next week for this. Bests, Benedek |
Summary
As a follow-up to #33, this PR adds a
duplicate_of
annotation to therexmex.utils.Annotator
class and begins annotating which functions are duplicate of each other.Caveat I'm not really happy with the direction of which is the "duplicate" in many cases, e.g., wheremiss_rate
is the "canonical" one and "false_negative_rate" is the duplicateChanges
duplicate_of
torexmex.utils.Annotator
precision_score
is a duplicate ofpositive_predictive_value
)pandas<=1.3.5
since they just put the 1.4 release candidate up on PyPI this morning and it doesn't work with the conda env in the GHA workflow