Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git dependencies #89

Open
Speak2Erase opened this issue Jan 17, 2024 · 2 comments
Open

Remove git dependencies #89

Speak2Erase opened this issue Jan 17, 2024 · 2 comments

Comments

@Speak2Erase
Copy link
Member

Git dependencies prevent us from being able to publish to crates.io (if we want to) and are also inherently unstable. Most of our git dependencies are for pull requests that haven't been merged yet (i.e. flume, cpal) or crates that haven't been updated on crates.io yet (catpuccin-egui).

The only exception to this is wezterm-term, which we use to handle most of the terminal functionality. We aren't really supposed to be using wezterm-term anyway, as it's a crate tailor made for wezterm and has no stability guarantees.

@Speak2Erase Speak2Erase added this to the v1.0 milestone Jan 17, 2024
@white-axe
Copy link
Collaborator

We should probably wait a little for the flume and cpal pull requests unless there's some rush. I think we may need to make a subtree for catppuccin-egui though because they update more slowly than all of our other dependencies that depend on egui and the crate itself is very small anyways.

How is the current version of Luminol going to be determined from inside of Luminol if we publish to crates.io? The git-version macro isn't going to work properly if some of the crates are at a different git version than the other ones, so would we have to make a new update for every crate every time any crate is updated?

@Speak2Erase
Copy link
Member Author

Speak2Erase commented Jan 17, 2024

Yeah, there's definitely no rush! I'm actually working on a theme editor so we can replace catppuccin-egui (luminol-preferences branch)

The version should probably be defined by the luminol crate? git-version is there more to pin down when a build was made (useful for checking if your browser is caching wasm builds)

@white-axe white-axe mentioned this issue Jan 20, 2024
5 tasks
@Speak2Erase Speak2Erase mentioned this issue Mar 8, 2024
5 tasks
@Speak2Erase Speak2Erase mentioned this issue Mar 21, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants