1.1.0 #163
1.1.0 #163
Conversation
LarsArtmann
added
bug
|
@DevSnox i need a review |
Fixed planet (set)home command & Deleted debug messages
Fix ArmorStand can't destroying by member / owner #188
… in ".../listeners/commands"
…nListener on(PlayerTeleportEvent)
|
1.1.0 is Done |
| } | ||
|
|
||
| fun Entity.isNotInGameWorld() = world.isNotGameWorld() | ||
| fun World.isNotGameWorld() = this != gameWorld |
There was a problem hiding this comment.
#isGameWorld would be better, wouldn't it?
There was a problem hiding this comment.
We don't need isGameWorld in the src anywhere
| players.forEach { it.save() } | ||
| } | ||
|
|
||
| fun Entity.isNotInGameWorld() = world.isNotGameWorld() |
There was a problem hiding this comment.
#isInGameWorld would be better, wouldn't it?
There was a problem hiding this comment.
We don't need isGameWorld in the src anywhere
There was a problem hiding this comment.
Yeah sure but why using directly using a negative boolean?
There was a problem hiding this comment.
So i don't need to ride ! for each function call
There was a problem hiding this comment.
Larger names for no reason.
It makes sense for having those positive because there is an operator check if negative "!" but no one if it's positive.
So the base value of a boolean returning method should be always of positive value.
There was a problem hiding this comment.
If you want, i can add a unused positive function, should i?
There was a problem hiding this comment.
Yeah sure cause "empty" is a negativ statment.
There was a problem hiding this comment.
I think we should discuss about that 😂
| fun findPlanet(planet: UniqueID): OfflinePlanet? | ||
|
|
||
| fun findPlayerOrCreate(owner: Owner, planet: UniqueID): OfflinePlayer | ||
| fun findPlanetOrCreate(planet: UniqueID, owner: Owner): OfflinePlanet |
There was a problem hiding this comment.
#findOrCreatePlanet() would be correct
There was a problem hiding this comment.
Das habe ich aufgrund von "findPlanet" gemacht (wegen den Vorschlägen)
| fun findPlayer(owner: Owner): OfflinePlayer? | ||
| fun findPlanet(planet: UniqueID): OfflinePlanet? | ||
|
|
||
| fun findPlayerOrCreate(owner: Owner, planet: UniqueID): OfflinePlayer |
There was a problem hiding this comment.
#findOrCreatePlayer() would be correct
There was a problem hiding this comment.
Das habe ich aufgrund von "findPlayer" gemacht (wegen den Vorschlägen)
No description provided.