Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make telescope-fzf more stand-alone #165

Merged
merged 1 commit into from Mar 19, 2022
Merged

Conversation

hunger
Copy link
Contributor

@hunger hunger commented Mar 19, 2022

The extension is the default anyway, so I just removed that...

This makes it possible to just disable the fzf plugin without killing the telescope plugin as well -- e.g. because you can not actually build the fzf binary this needs:-)

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit 889dfda into AstroNvim:main Mar 19, 2022
@AXGKl
Copy link

AXGKl commented Mar 19, 2022

Hi, just tried astrovim on a clean server, worked, liked it.

=> installed on my laptop, got this error:

2022-03-20_

back to the server, git pull (got this PR now, was merged 2 hours before) => same error

I.e. the error is definitely caused by this PR, git checkout from before and it worked again.

@mehalter
Copy link
Member

@AXGKl This should be fixed with #167 sorry for the issue!

@AXGKl
Copy link

AXGKl commented Mar 19, 2022

for what it's worth: #167 fixes it for me as well, on both machines.

@mehalter
Copy link
Member

Ok thanks! Hopefully when @kabinspace is around he can approve and merge my PR :)

@hunger hunger deleted the fzf_standalone branch March 21, 2022 08:24
mchristou pushed a commit to mchristou/AstroNvim that referenced this pull request Mar 12, 2024
Make telescope-fzf more stand-alone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants