Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove conflicting rn binding #193

Merged
merged 1 commit into from Mar 23, 2022
Merged

remove conflicting rn binding #193

merged 1 commit into from Mar 23, 2022

Conversation

mehalter
Copy link
Member

Renaming is taken care of with the <leader>lr binding and rn conflicts with replacing a character with n

@mehalter mehalter added the bug Something isn't working label Mar 23, 2022
@mehalter mehalter self-assigned this Mar 23, 2022
@mehalter mehalter changed the title remove conclicting rn binding remove conflicting rn binding Mar 23, 2022
@abalmos
Copy link

abalmos commented Mar 23, 2022

Would <leader>rn be more natural?

@mehalter
Copy link
Member Author

@abalmos I think that would be a good option. I think the process we were using is we want the which-key menu to be nicely organized especially for people learning the new bindings through which-key. Where <leader>l covers all of the LSP functionality. I will leave this up to @kabinspace since it's his project and anything that is set by default can always be changed in my own user files if it is not generally agreed on :)

@mehalter
Copy link
Member Author

Another option is we can keep the <leader>lr for a which-key menu item and just have <leader>rn work anyway. @abalmos and it just be listed on the wiki under default bindings.

Signed-off-by: Micah Halter <micah@balena.io>
@kabinspace kabinspace merged commit c1cd72d into main Mar 23, 2022
@mehalter mehalter deleted the rename_binding branch March 23, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants