Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(options): don't set smartindent #2136

Merged
merged 1 commit into from Jul 17, 2023
Merged

fix(options): don't set smartindent #2136

merged 1 commit into from Jul 17, 2023

Conversation

ryan4yin
Copy link
Contributor

@ryan4yin ryan4yin commented Jul 17, 2023

Any lines starting with a # is unable to be indented with smartindent

Related issues:

I confirmed this problem also exist in AstroNvim.

AstroNvim

  • AstroNvim Version: v3.33.2
  • Neovim Version: v0.9.1
  • OK Using stable Neovim >= 0.8.0
  • OK git is installed: Used for core functionality such as updater and plugin management
  • OK xdg-open is installed: Used for gx mapping for opening files with system opener (Optional)
  • WARNING lazygit is not installed: Used for mappings to pull up git TUI (Optional)
  • OK node is installed: Used for mappings to pull up node REPL (Optional)
  • OK gdu is installed: Used for mappings to pull up disk usage analyzer (Optional)
  • WARNING btm is not installed: Used for mappings to pull up system monitor (Optional)
  • OK python is installed: Used for mappings to pull up python REPL (Optional)

Operating System

NixOS 23.05 & macOS 13.4.1

Terminal

kitty & alacritty

Screenshots

astronvim-indentation-issue.webm

@github-actions
Copy link

Use the following updater settings in your user/init.lua file, restart, and run :AstroUpdate to test this pull request:

  updater = {
    channel = "nightly",
    branch = "disable-smartindent",
    remote = "coding-and-typing",
    remotes = {
      ["coding-and-typing"] = "coding-and-typing/AstroNvim",
    },
  },

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks! We should just remove the line since false is the neovim default and we don't want to redefine default options.

lua/astronvim/options.lua Outdated Show resolved Hide resolved
@mehalter mehalter changed the title fix: disable smartindent fix(options): don't set smartindent Jul 17, 2023
@ryan4yin
Copy link
Contributor Author

@mehalter Yep, updated.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

@mehalter mehalter merged commit fb72032 into AstroNvim:nightly Jul 17, 2023
4 checks passed
@ryan4yin ryan4yin deleted the disable-smartindent branch July 17, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants