Move binding setting to which-key for easier user override in config #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabinspace
approved these changes
Apr 11, 2022
Signed-off-by: Micah Halter <micah@balena.io>
mehalter
force-pushed
the
which_key_bindings
branch
from
2e766f7
to
cba5c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up which-key assigning mappings if it is available and
mappings.luaassigning mappings if it is not. This does require core maintenance to duplicate code for leader and non-leader mappings but on the user side ifwhich-keyis used the user can simply override the which-key register table without also having to unmap or delete mappings as well.