Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional terminal numbers to toggle term #307

Merged
merged 1 commit into from Apr 18, 2022

Conversation

kraxli
Copy link
Contributor

@kraxli kraxli commented Apr 17, 2022

enhance #300 by providing (optional) terminal number

e.g. key stroke 4tp with open python in terminal number 4

@mehalter
Copy link
Member

Thanks for the contribution! @kraxli could you please rebase your commits into a single commit. We are not allowing any merge commits in main to keep a linear commit log.

@mehalter mehalter changed the title Astronvim Add optional terminal numbers to toggle term Apr 17, 2022
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty great! I suggested one line change and other than that I just need you to rebase the commits back down to a single commit instead of having merge and revert commits.

lua/core/utils.lua Outdated Show resolved Hide resolved
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing, its quite close. Can you please drop the unrelated commit that changes bufferline autocommands. Seems to be a problem with the Rebase.

@kraxli
Copy link
Contributor Author

kraxli commented Apr 18, 2022

thanks, I followed your suggestion. Hope it fits now :-)

@mehalter mehalter added the enhancement New feature or request label Apr 18, 2022
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit 983d992 into AstroNvim:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants