feat(lsp): allow user defined per lsp on_attach additions #586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows additions to the
on_attach
function for specific language servers in thelsp.server-settings
table. This was completely incorrectly handled and honestly could be considered just a flat out bug until now. For example, disabling formatting for a single language server can now look like this:Also makes it easier to disable our custom
on_attach
for specific languages, like if a user wants to usetsserver
formatting they can just do this: