Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): update for the latest settings hierarchy #1020

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

liujoey
Copy link
Contributor

@liujoey liujoey commented May 31, 2024

📑 Description

jdtls changed the settings hierarchy; for instance, they moved settings.completion to settings.java.completion.
This PR moved these settings.

ℹ Additional Information

This document described the most recent setting hierarchy:
Jdtls Initialize Request

Copy link

github-actions bot commented May 31, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@liujoey liujoey changed the title update pack/java for the latest settings hierarchy fix(pack/java) update for the latest settings hierarchy May 31, 2024
@liujoey liujoey changed the title fix(pack/java) update for the latest settings hierarchy fix(pack/java): update for the latest settings hierarchy May 31, 2024
@liujoey liujoey changed the title fix(pack/java): update for the latest settings hierarchy fix(java): update for the latest settings hierarchy May 31, 2024
@Uzaaft Uzaaft merged commit 95e8b3f into AstroNvim:main Jun 1, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants