Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bit-combine-bracken-and-add-lineage to allow users to pass a custom location for the taxonkit database #16

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

sterrettJD
Copy link
Contributor

Hey Mike, thanks for this nice toolkit :)

Recently, I've been wanting to use bit-combine-bracken-and-add-lineage without relying on the taxonkit database being stored in the root directory. Instead of the default ~/.taxonkit, I want users of a tool I'm developing to be able to place this in the working directory.

Maybe I'm missing a better way to do this, but I updated bit-combine-bracken-and-add-lineage to accommodate this, and it worked for me. Users can now pass various paths for this database, and it defaults to ~/.taxonkit if nothing is passed.

I did this by adding an argument -d to the script, then passing that to the taxonkit --data-dir argument.

Let me know what you think about this approach and if you'd be interested in incorporating this in the toolkit. Happy to make some adjustments if needed.

Thanks,
John

@AstrobioMike
Copy link
Owner

awesome! Looks clean and straightforward to me, I'll merge and update the conda version :)

thanks, John!

@AstrobioMike AstrobioMike merged commit d984c06 into AstrobioMike:master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants