Skip to content
This repository has been archived by the owner on Nov 20, 2020. It is now read-only.

Finish bindings for useQuery #1

Closed
fakenickels opened this issue May 2, 2019 · 13 comments
Closed

Finish bindings for useQuery #1

fakenickels opened this issue May 2, 2019 · 13 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fakenickels
Copy link
Member

  • fetchMore
  • refetch
@fakenickels fakenickels added help wanted Extra attention is needed good first issue Good for newcomers labels May 2, 2019
@hew
Copy link
Contributor

hew commented Jun 7, 2019

It seems like I can't make a query where I pass through options. Is that the result of the unfinished bindings, or do you think I am just doing something wrong?

@hew
Copy link
Contributor

hew commented Jun 7, 2019

Regardless, I'll see if I can finish this up.

@fakenickels
Copy link
Member Author

@hew
Copy link
Contributor

hew commented Jun 7, 2019

Yeah when I provide ~options, I can't return the (simple, full) tuple. But if I don't pass options, I can.

@hew
Copy link
Contributor

hew commented Jun 7, 2019

Ah, nevermind. I had (~options) vs (~options, ()). My mistake!

@fakenickels
Copy link
Member Author

oh I see!
maybe there is another way to make this more explicit for users? Point about that in the README?

@hew
Copy link
Contributor

hew commented Jun 9, 2019

I think what I will do that might be of broader use is write a blog post on common compiler errors in reason that include this one. I think it's less a problem with this library's API design or readme, and more that the optional labeled arguments syntax is 1.) easy to forget, and 2.) isn't really pointed out that well by the compiler.

@fakenickels
Copy link
Member Author

That makes sense!

@fakenickels
Copy link
Member Author

@fakenickels
Copy link
Member Author

refetch bound, now just fetchMore missing

@MargaretKrutikova
Copy link
Collaborator

I just wanted to rewrite an app from reason-apollo into reason-apollo-hooks and need fetchMore, so I would be glad to help write bindings for it. Is someone already working on it?

I was also thinking about including network status in the same change since it seems useful to distinguish between just loading status and fetching more, NetworkStatus type from apollo-client package.

@fakenickels
Copy link
Member Author

fakenickels commented Aug 12, 2019

None of us are working on it, your help here would be much appreciated!

@MargaretKrutikova
Copy link
Collaborator

Great! I will start working on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants