Skip to content
This repository has been archived by the owner on Nov 20, 2020. It is now read-only.

Add fetch more and network status to useQuery #25

Merged
merged 4 commits into from Aug 15, 2019
Merged

Add fetch more and network status to useQuery #25

merged 4 commits into from Aug 15, 2019

Conversation

MargaretKrutikova
Copy link
Collaborator

Addresses missing bindings for fetchMore in #1 .

What this PR does:

  • adds bindings for fetch more option to query (the types are mostly taken from reason-apollo with some pointers to the original TS definitions to make easier updates in the future),
  • adds bindings for networkStatus that can be used to track whether fetchMore is in progress,
    the original definition is located in apollo-client,
  • adds an example project based on swapi example from reason-apollo with usage of the query hook using fetchMore and networkStatus.

Does it make sense to include links to the original TS definition from apollo packages? From my experience it might help other people figure out how the bindings work, do troubleshooting or update the bindings in case the original definition changes. But, it clutters the code a bit.

Appreciate any advice on this and/or a code review 馃檪

@fakenickels
Copy link
Member

this is amazing! we're going to take a look soon

@guilhermedecampo
Copy link

@fakenickels @medson10

image

@fakenickels fakenickels merged commit d0f3c5d into reasonml-community:master Aug 15, 2019
@fakenickels
Copy link
Member

Released under v2.4.0, thanks a lot @MargaretKrutikova!

@MargaretKrutikova MargaretKrutikova deleted the query-fetch-more branch September 14, 2019 12:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants