Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resume builder added #77

Merged
merged 1 commit into from
Oct 2, 2021
Merged

resume builder added #77

merged 1 commit into from
Oct 2, 2021

Conversation

tarce09
Copy link
Contributor

@tarce09 tarce09 commented Oct 2, 2021

issue no #78
Hello sir,
I added a html, css and js based resume builder where you can fill in your details in a professionally designed resume and download the resume in pdf format.
I would be very glad if you accept my pr
the file name is resume_builder in the assets folder

@NOiR-07
Copy link
Collaborator

NOiR-07 commented Oct 2, 2021

@tarce09 Always first raise the issue and when it's assigned to you then raise the pr, do the same for this
Also, try to put the ss/gif of your running project so that we can verify

@tarce09
Copy link
Contributor Author

tarce09 commented Oct 2, 2021

thank you for your guidance i have added the issue,
do i have to pull req again or will this pull request be good

@NOiR-07
Copy link
Collaborator

NOiR-07 commented Oct 2, 2021

thank you for your guidance i have added the issue, do i have to pull req again or will this pull request be good

Just mention the issue tag

@tarce09
Copy link
Contributor Author

tarce09 commented Oct 2, 2021

i have mentioned the issue tag by editing the initial comment of the pull request is it fine now

@NOiR-07 NOiR-07 linked an issue Oct 2, 2021 that may be closed by this pull request
@NOiR-07 NOiR-07 merged commit eb427ba into Astrodevil:main Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding resume builder
2 participants