Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not updating with Nova #162

Closed
u12206050 opened this issue Jul 29, 2020 · 11 comments
Closed

Not updating with Nova #162

u12206050 opened this issue Jul 29, 2020 · 11 comments
Assignees
Labels

Comments

@u12206050
Copy link

Describe the bug
I am using this with Nova, but none of the translatable fields seem to be updating.

To Reproduce
Install Nova v3
Setup a model and resource that is translatable
Create a new resource, and then try and update its fields
Only non-translatable fields are updated without any error

Expected behavior
All fields are updated

Versions (please complete the following information)

  • PHP: 7.4
  • Database: mysql
  • Laravel: 7.22
  • Package: Nova v3.8.2

Exception
None

@u12206050 u12206050 added the bug label Jul 29, 2020
@u12206050
Copy link
Author

Create a PR #163 that fixes this issue

@stale
Copy link

stale bot commented Aug 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 12, 2020
@u12206050
Copy link
Author

Any updates on publishing the PR?

@stale stale bot removed the stale label Aug 13, 2020
@Gummibeer
Copy link
Member

Hey,

sorry for the delay. And thanks for your work.

Except of the failing tests I have some fundamental questions about the issue.

So far I've seen in the PR the issue is that Nova uses the translation (singular) relation instead of the translations (original) one!?
If that's the case how's your Nova setup? Do you use any package make this package work with Nova?

@Gummibeer Gummibeer self-assigned this Aug 13, 2020
@u12206050
Copy link
Author

Hei, I use this with my own personal version of switch-locale

@stale
Copy link

stale bot commented Aug 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 28, 2020
@u12206050
Copy link
Author

Btw, I have refactored and cleaned up the code a bit. It seems like Nova uses the singular due to it being just one field and it doesn't see it as a direct relationship, probably due to the abstraction that laravel-translatable does.

@stale stale bot removed the stale label Aug 29, 2020
@stale
Copy link

stale bot commented Sep 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 12, 2020
@jezzdk
Copy link

jezzdk commented Mar 16, 2021

@u12206050 Did you find a solution to this?

@u12206050
Copy link
Author

u12206050 commented Mar 16, 2021 via email

@Gummibeer
Copy link
Member

Seems that this relates to #215 and is based in the usage of translation instead of translations.
There's a package for nova that doesn't do anything related to this: https://github.com/yeswedev-team/ywd_nova-translatable
So it's not a general conflict with nova.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants