Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Facade for PageFactory #10

Merged
merged 3 commits into from Oct 7, 2019
Merged

Added Facade for PageFactory #10

merged 3 commits into from Oct 7, 2019

Conversation

Djuki
Copy link
Contributor

@Djuki Djuki commented Oct 4, 2019

Please review and let me know is this what you wanted re #7

Copy link
Member

@Gummibeer Gummibeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work.
I've two CRs:

  • the methods are static on the facade - you call them PageFactory::make()
  • the alias should follow the other alias uses and better show that it's an interface and not a real class.

In addition I would like to allow auto-discovery for the facade: https://laravel-news.com/package-auto-discovery Can you implement this?

And the StyleCI test should pass. Yo can download the raw diff from StyleCI test site and apply it as a patch.

src/Facades/PageFactory.php Outdated Show resolved Hide resolved
src/Facades/PageFactory.php Outdated Show resolved Hide resolved
src/Facades/PageFactory.php Outdated Show resolved Hide resolved
src/Facades/PageFactory.php Outdated Show resolved Hide resolved
src/Facades/PageFactory.php Outdated Show resolved Hide resolved
@Djuki
Copy link
Contributor Author

Djuki commented Oct 4, 2019

@Gummibeer Will do all of that, thanks for the review. You can expect a new push Tomorrow.

@Djuki Djuki requested a review from Gummibeer October 5, 2019 07:07
@Gummibeer
Copy link
Member

Thanks for fixing it! 😊
Will merge it later.

@Gummibeer Gummibeer merged commit db725cc into Astrotomic:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants