Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/windows compatibility #13

Merged
merged 7 commits into from
Oct 23, 2018
Merged

Feature/windows compatibility #13

merged 7 commits into from
Oct 23, 2018

Conversation

Robert-W
Copy link
Contributor

We encountered two issues when running on windows:

  • Invalid RegExp with paths in routing
  • semi-colon on scripts in package.json

We updated a couple of other places where we were using just path and not path.posix

@Robert-W Robert-W added the enhancement New feature or request label Oct 22, 2018
@Robert-W Robert-W self-assigned this Oct 22, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 55

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 50: 0.0%
Covered Lines: 147
Relevant Lines: 147
💛 - Coveralls

@Robert-W Robert-W merged commit c079bc6 into develop Oct 23, 2018
@Robert-W Robert-W deleted the feature/windows-compatibility branch October 23, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonterrylee jonterrylee jonterrylee approved these changes

@lu-c lu-c Awaiting requested review from lu-c

Assignees

@Robert-W Robert-W

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robert-W @coveralls @jonterrylee