minor clean up

AsyncHttpClient · Apr 28, 2015 · 64acaa1 · 64acaa1
1 parent 1d3badf
commit 64acaa1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/api/src/main/java/org/asynchttpclient/util/AsyncHttpProviderUtils.java b/api/src/main/java/org/asynchttpclient/util/AsyncHttpProviderUtils.java
@@ -96,6 +96,12 @@ public final static String getAuthority(Uri uri) {
         return uri.getHost() + ":" + port;
     }
 
+    public final static boolean isSameHostAndProtocol(Uri uri1, Uri uri2) {
+        return uri1.getScheme().equals(uri2.getScheme())
+                && uri1.getHost().equals(uri2.getHost())
+                && getDefaultPort(uri1) == getDefaultPort(uri2);
+    }
+
     public final static int getDefaultPort(Uri uri) {
         int port = uri.getPort();
         if (port == -1)

diff --git a/providers/netty3/src/main/java/org/asynchttpclient/providers/netty3/handler/Protocol.java b/providers/netty3/src/main/java/org/asynchttpclient/providers/netty3/handler/Protocol.java
@@ -155,12 +155,8 @@ protected boolean exitAfterHandlingRedirect(//
                     logger.debug("Sending redirect to {}", request.getUri());
 
                     if (future.isKeepAlive() && !HttpHeaders.isTransferEncodingChunked(response) && !response.isChunked()) {
-
-                        boolean redirectToSameHost = request.getUri().getScheme().equals(nextRequest.getUri().getScheme())
-                                && request.getUri().getHost().equals(nextRequest.getUri().getHost())
-                                && getDefaultPort(request.getUri()) == getDefaultPort(nextRequest.getUri());
 
-                        if (redirectToSameHost) {
+                        if (isSameHostAndProtocol(request.getUri(), nextRequest.getUri())) {
                             future.setReuseChannel(true);
                         } else {
                             channelManager.drainChannelAndOffer(channel, future, initialConnectionKeepAlive, initialPartition);

diff --git a/providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/handler/Protocol.java b/providers/netty4/src/main/java/org/asynchttpclient/providers/netty4/handler/Protocol.java
@@ -156,12 +156,8 @@ protected boolean exitAfterHandlingRedirect(//
                     logger.debug("Sending redirect to {}", request.getUri());
 
                     if (future.isKeepAlive() && !HttpHeaders.isTransferEncodingChunked(response)) {
-
-                        boolean redirectToSameHost = request.getUri().getScheme().equals(nextRequest.getUri().getScheme())
-                                && request.getUri().getHost().equals(nextRequest.getUri().getHost())
-                                && getDefaultPort(request.getUri()) == getDefaultPort(nextRequest.getUri());
 
-                        if (redirectToSameHost) {
+                        if (isSameHostAndProtocol(request.getUri(), nextRequest.getUri())) {
                             future.setReuseChannel(true);
                             requestSender.drainChannelAndExecuteNextRequest(channel, future, nextRequest);